Update vboxServiceWrappers.php and vboxweb-6.0.wsdl to fix mismatch a…#172
Update vboxServiceWrappers.php and vboxweb-6.0.wsdl to fix mismatch a…#172maxcalandrelli wants to merge 1 commit intophpvirtualbox:developfrom
Conversation
…mong ISharedFolder stub (phpvirtualbox, VBox_Struct, incorrect) and skeleton (vboxweb, VBox_ManagedObject)
|
Thanks for the PR. Can you explain this? $request->autoMountPoint = "/media/sf_" . $arg_name; It looks like something's being hardcoded here, possibly specific to your OS? I certainly don't have anything with that path in it. |
|
It's the actual default naming for linux guests. It should become
parametric, but I just had to fix it quickly. I was about to go further,
but there were 2 considerations that kept me from doing so:
1) the actual code has no such parameter and the same (or a similar) name
building scheme is likely to be hardcoded deep inside vboxwebsrv binary
2) windows guests do not need nor use that value, because the do not see
any mounted local path, just an UNC
So, having covered most of kernels running around, I felt quite satisfied
and released the PR.
Il giorno mar 25 giu 2019 alle ore 05:00 h6w <notifications@github.com> ha
scritto:
… Thanks for the PR. Can you explain this?
$request->autoMountPoint = "/media/sf_" . $arg_name;
It looks like something's being hardcoded here, possibly specific to your
OS? I certainly don't have anything with that path in it.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#172?email_source=notifications&email_token=AANSUOAZ3JWYEL6ONBQEVMTP4GC3DA5CNFSM4H2TJ4U2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYO2UGY#issuecomment-505260571>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AANSUOBWVFDNGC6TBXNJDLTP4GC3DANCNFSM4H2TJ4UQ>
.
|
|
@h6w If this is VBox 6.0 support then can you give it more attention? |
|
@rozhuk-im "develop" branch supports VirtualBox 6.0.16 (and is used in production) with the exception of Nested Virtualization (working PR not merged) and selection of VGA adapters (PR not working). There are also issues with Shared Folder feature which would only work with updated WDSL from what I remember. |
|
Hai, develop branch now includes WSDL updated to 6.1 and all outstanding 6.0 feature PRs. @maxcalandrelli and others, can you test if develop branch fixes the issues adressed here? If so, please consider closing this PR. If there are outstanding issues, please open an issue. |
…mong ISharedFolder stub (phpvirtualbox, VBox_Struct, incorrect) and skeleton (vboxweb, VBox_ManagedObject)