8000 Add generics for PasswordUpgraderInterface by VincentLanglet · Pull Request #318 · phpstan/phpstan-symfony · GitHub
[go: up one dir, main page]
Skip to content

Add generics for PasswordUpgraderInterface #318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 22, 2022
Merged

Add generics for PasswordUpgraderInterface #318

merged 2 commits into from
Dec 22, 2022

Conversation

VincentLanglet
Copy link
Contributor

This is symfony/symfony#48750 but for older Symfony version.
I'll wait for the Symfony merge this.

@VincentLanglet VincentLanglet marked this pull request as ready for review December 22, 2022 14:43
@VincentLanglet
Copy link
Contributor Author
VincentLanglet commented Dec 22, 2022 •
edited
Loading

symfony/symfony#48750 was merged so this is ready to be merged @ondrejmirtes

@ondrejmirtes
Copy link
Member

I can only merge this if the new generic class is added to skipCheckGenericClasses in extension.neon.

@VincentLanglet
Copy link
Contributor Author

skipCheckGenericClasses

Done !
What's the idea behind ? Is it for BC purpose ?

@ondrejmirtes
Copy link
Member

Yes, I'm gonna empty it in the next major version.

@ondrejmirtes ondrejmirtes merged commit dac2474 into phpstan:1.2.x Dec 22, 2022
@ondrejmirtes
Copy link
Member

Thank you!

@VincentLanglet
Copy link
Contributor Author

Yes, I'm gonna empty it in the next major version.

I assume that if you use bleedingEdge, skipCheckGenericClasses has no effect ?

@ondrejmirtes
Copy link
Member

There's https://github.com/phpstan/phpstan-src/blob/3408a97088d6af676114814fa83455b11ac4da76/conf/bleedingEdge.neon#L4 but I think that only applies to https://github.com/phpstan/phpstan-src/blob/3408a97088d6af676114814fa83455b11ac4da76/conf/config.neon#L23-L33 because phpstan-symfony config is applied later. Anyway, you can verify this yourself :)

@VincentLanglet VincentLanglet deleted the passwordUpgrader branch December 22, 2022 20:22
@VincentLanglet VincentLanglet mentioned this pull request Jul 10, 2023
Closed
@ondrejmirtes ondrejmirtes mentioned this pull request Mar 20, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VincentLanglet @ondrejmirtes
0