This fixes issue #908 #909
Conversation
| if ((iptr = INI_STR("redis.arrays.index")) != NULL) { | ||
| sapi_module.treat_data(PARSE_STRING, estrdup(iptr), z_params_index TSRMLS_CC); | ||
| } | ||
| if (zend_hash_find(Z_ARRVAL_P(z_params_index), name, name_len, (void **) &z_data_pp) != FAILURE) { | ||
| if(Z_TYPE_PP(z_data_pp) == IS_STRING && strncmp(Z_STRVAL_PP(z_data_pp), "1", 1) == 0) { |
There was a problem hiding this comment.
@michael-grunder, is it possible to compare single char instead of using strncmp?
Something like *Z_STRVAL_PP(z_data_pp) == '1'
There was a problem hiding this comment.
Yes, that should work. That being said, I don't think this code is any kind of performance bottleneck.
There was a problem hiding this comment.
OK, let's leave it as is. As for me it is more readable with strcmp
|
Hey man, this looks fine to me. Also, you are perfectly welcome to just merge things. That's why these are develop versions of the code 😺. Don't worry, people will let us know if stuff breaks! |
Apply changes from PR #909
|
@michael-grunder, as I'm a newbie in php extensions development I'm not always sure of some things and what they exactly do, so I'm still need a peace of your attention to review code :) |
|
No worries. You're pretty good in C which is really all that's required. Basically the rest is fighting the zend api :) |
No description provided.