8000 Added a composer.json to enable support for PIE by asgrim · Pull Request #2546 · phpredis/phpredis · GitHub
[go: up one dir, main page]
Skip to content

Added a composer.json to enable support for PIE #2546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 20, 2024
Merged

Added a composer.json to enable support for PIE #2546

merged 1 commit into from
Sep 20, 2024

Conversation

asgrim
Copy link
Contributor
@asgrim asgrim commented Sep 18, 2024

Adds support for PIE.

Once merged, a maintainer would need to add this repo's URL to https://packagist.org/packages/submit :)

More info/documentation can be read on: https://github.com/php/pie/blob/main/docs/extension-maintainers.md

asgrim
asgrim commented Sep 19, 2024
View reviewed changes
@michael-grunder
Copy link
Member

This is neat. Is PIE intended to replace pecl?

@yatsukhnenko Seems like it should be fine to merge pre-6.1.0RC2

@asgrim
Copy link
Contributor Author
asgrim commented Sep 19, 2024

This is neat. Is PIE intended to replace pecl?

@yatsukhnenko Seems like it should be fine to merge pre-6.1.0RC2

Yep, the goal is to eventually replace PECL for new extension releases (although PECL will not disappear, otherwise so much stuff will break!) - just trying to onboard a few more extensions at the moment, so we can ensure things will work; it's not quite ready for prime time, but we hope to have a working "0.0.1" release out to coincide with PHP 8.4 release in Nov.

If you do spot any issues when trying things out, please do let me know! :)

@yatsukhnenko
Copy link
Member

@michael-grunder if I correctly understand we don't need to add this file to pecl package so it's safe to merge it to 6.1.0RC2

< 8000 /td>

@michael-grunder michael-grunder merged commit b59e35a into phpredis:develop Sep 20, 2024
22 of 30 checks passed
@michael-grunder
Copy link
Member

Merged and submitted, thanks!

Let me know if you need anything else from us.

@asgrim asgrim deleted the add-support-for-pie branch September 20, 2024 18:28
@asgrim
Copy link
Contributor Author
asgrim commented Sep 20, 2024

Thanks, works nicely! 👌

$ bin/pie install --with-php-config=/home/james/workspace/oss/php-src-build/bin/php-config phpredis/phpredis:dev-develop
This command may need elevated privileges, and may prompt you for your password.
You are running PHP 8.3.11
Target PHP installation: 7.4.33 ts, on Linux/OSX/etc x86_64 (from /home/james/workspace/oss/php-src-build/bin/php)
Found package: phpredis/phpredis:dev-develop which provides ext-redis
phpize complete.
Configure complete with options: --with-php-config=/home/james/workspace/oss/php-src-build/bin/php-config
Build complete: /tmp/pie_downloader_66edbf31e4f998.58310460/phpredis-phpredis-b59e35a/modules/redis.so
Install complete: /home/james/workspace/oss/php-src-build/lib/php/extensions/debug-zts-20190902/redis.so
You must now add "extension=redis" to your php.ini

thank you folks!

@kohenkatz kohenkatz mentioned this pull request Nov 22, 2024
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-grunder michael-grunder michael-grunder left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@asgrim @michael-grunder @yatsukhnenko
0