Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update these external scripts to take formal arguments with
getopt
to make it more straightforward what each of the currently positional arguments are actually for.Create small helper classes for invoking these external scripts. Instead of
startSessionProcess
that takes a dozen arguments all but three of which have defaults, we can use a construct like this:Add a bit of logic to TestSuite to dump more information about the source of an assertion to make it easier to track down problems when we assert outside of a top level public
test_*
method.Create a few new assertions like
assertKeyExists
andassertKeyMissing
which will generate much nicer assertions as opposed to