8000 Fix deprecation error when passing null to match_type parameter by yatsukhnenko · Pull Request #2405 · phpredis/phpredis · GitHub
[go: up one dir, main page]
Skip to content

Fix deprecation error when passing null to match_type parameter #2405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 13, 2023
Merged

Fix deprecation error when passing null to match_type parameter #2405

merged 1 commit into from
Oct 13, 2023

Conversation

yatsukhnenko
Copy link
Member
@yatsukhnenko yatsukhnenko commented Oct 13, 2023 •
edited
Loading

Fixes #2403

@yatsukhnenko
Copy link
Member Author

@michael-grunder it may be worth rewrite parsing parameters to newer fast zpp api
Also I found that for RedisCluster::scan first parameter is iterator and second is a host. I think this is a bug because for all other commands host goes as the first parameter

@yatsukhnenko yatsukhnenko mentioned this pull request Oct 13, 2023
Closed
@ruudk
Copy link
Contributor
ruudk commented Oct 13, 2023

I can confirm that this solves the problem from #2403 🎉 Thanks!

@yatsukhnenko yatsukhnenko merged commit e7910dc into develop Oct 13, 2023
@yatsukhnenko yatsukhnenko deleted the issue-2403 branch October 13, 2023 21:27
@ruudk
Copy link
Contributor
ruudk commented Oct 14, 2023

Thank you. Could you tag a new release on PECL?

@ruudk ruudk mentioned this pull request Oct 17, 2023
Closed
mrkhish pushed a commit to mrkhish/phpredis that referenced this pull request Feb 18, 2024
@yatsukhnenko @mrkhish
Merge pull request phpredis#2405 from phpredis/issue-2403
9595b09 
Fix deprecation error when passing null to match_type parameter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-grunder michael-grunder michael-grunder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Redis::scan(): Passing null to parameter #4 ($type) of type ?string is deprecated
3 participants
@yatsukhnenko @ruudk @michael-grunder
0