Fix LZF decompression logic. #2065
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rework how we decompress LZF data. Previously it was possible to encounter a double-free, if the error was not E2BIG.
yatsukhnenko
approved these changes
Jan 26, 2022
| data = emalloc(i * len); | ||
| if ((res = lzf_decompress(src, len, data, i * len)) == 0) { | ||
| /* errno != E2BIG will brake for loop */ | ||
| efree(data); |
There was a problem hiding this comment.
Why not just set data = NULL here after efree? 🙂
yatsukhnenko
pushed a commit
that referenced
this pull request
Feb 1, 2022
* Fix LZF decompression logic. Rework how we decompress LZF data. Previously it was possible to encounter a double-free, if the error was not E2BIG. * .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rework how we decompress LZF data. Previously it was possible to
encounter a double-free, if the error was not E2BIG.