8000 Normalize Redis callback prototypes and stop typecasting. by michael-grunder · Pull Request #1935 · phpredis/phpredis · GitHub
[go: up one dir, main page]

Skip to content

Normalize Redis callback prototypes and stop typecasting. #1935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 25, 2021

Conversation

michael-grunder
Copy link
Member

Convert every single Redis callback function to the form:

int callback(INTERNAL_FUNCTION_PARAMETERS, RedisSock*, zval*, void*);

Additionally, stop typcasting the callback to void* which was
suppressing warnings and exposing a segfault on Apple silicon (#1917).

Convert every single Redis callback function to the form:

int callback(INTERNAL_FUNCTION_PARAMETERS, RedisSock*, zval*, void*);

Additionally, stop typcasting the callback to void* which was
suppressing warnings and exposing a segfault on Apple silicon (#1917).
@michael-grunder michael-grunder merged commit e61ee1d into develop Feb 25, 2021
@michael-grunder michael-grunder deleted the issue.1917-callback-segfault branch February 25, 2021 18:03
@lonnylot
Copy link

Any ETA on when this will be tagged in a release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0