Fixed checks for lzf when headers are inside include/liblzf (ubuntu 20.04) #1778
Fixed checks for lzf when headers are inside include/liblzf (ubuntu 20.04) #1778iliaal wants to merge 1 commit intophpredis:developfrom
Conversation
|
IMHO, should be better to rely on pkg-config output, especially as this is now the default way for lot of libraries (7.4+) |
The issue is that pkg-config may not be installed. For example ubuntu 20.04 or 18.04 by default doesn't seem to include it, even with dev tools installed |
|
BTW, I didn't mean that this change is bad, both PR can be merged, only that |
That makes sense, if pkg-config available it clearly is a cleaner approach, if it doesn't then the older approach with patch I think is a valid solution |
|
@michael-grunder What do you think? |
Fixed checks for lzf when headers are inside include/liblzf (ubuntu 20.04)
In some distributions lzf.h is not inside include/ but instead in include/libzlf this tweak adds extra checks for that allowing lzf support to be enabled.
Updated PR to be based on develop branch