8000 Fix #1056 failed test on 32bits by remicollet · Pull Request #1078 · phpredis/phpredis · GitHub
[go: up one dir, main page]

Skip to content

Fix #1056 failed test on 32bits #1078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 22, 2016
Merged

Fix #1056 failed test on 32bits #1078

merged 3 commits into from
Dec 22, 2016

Conversation

remicollet
Copy link
Collaborator

No description provided.

@remicollet
Copy link
Collaborator Author

Still 1 failure on armv7hl
Assertion failed (1.8 !== 1.80000000000000004): /builddir/build/BUILD/php-pecl-redis-3.1.1/NTS/tests/RedisTest.php:556 (testIncrByFloat)
Working on it

@remicollet
Copy link
Collaborator Author
remicollet commented Dec 22, 2016

Everything seems ok now.

See https://koji.fedoraproject.org/koji/taskinfo?taskID=17024279 (i686, x86_64, ppc64, ppc64le, armv7hl, aarch64). Build + test suite OK

@yatsukhnenko
Copy link
Member

@remicollet, any chance to receive access to your building environment for testing new features of phpredis?

@remicollet
Copy link
Collaborator Author
remicollet commented Dec 22, 2016

@yatsukhnenko this is the Fedora build system used by Fedora package maintainers.

BTW, you can probably use Copr which is specially design for upstream projects (no arm arch for now).

In all case, only RPM build are supported.

@michael-grunder michael-grunder merged commit 5fcd6dc into phpredis:develop Dec 22, 2016
@michael-grunder
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0