8000 `phpbrew use` doesn't work for non-release versions by morozov · Pull Request #798 · phpbrew/phpbrew · GitHub
[go: up one dir, main page]
Skip to content

phpbrew use doesn't work for non-release versions#798

Merged
jhdxr merged 1 commit intophpbrew:masterfrom
morozov:use-non-release-version
Nov 17, 2016
Merged

phpbrew use doesn't work for non-release versions#798
jhdxr merged 1 commit intophpbrew:masterfrom
morozov:use-non-release-version

Conversation

@morozov
Copy link
Contributor
@morozov morozov commented Oct 13, 2016

When switching to a release version, say 5.6.26, one can omit or preserve the php- prefix, and both phpbrew use 5.6.26 and phpbrew use php-5.6.26 will work as expected. While in case of a non-release version, say 7.1.0RC3, only the approach with the prefix works:

↪  phpbrew list
  php-7.1.0RC3   
* php-7.0.11     
  php-5.6.26     
  php-5.5.38     
  php-5.4.45     
  php-5.3.29     

↪  phpbrew use 5.6.26

↪  php --version
PHP 5.6.26 (cli) (built: Sep 28 2016 14:10:31) 

↪  phpbrew use 7.1.0RC3
php version: 7.1.0RC3 not exists.

↪  phpbrew use php-7.1.0RC3

↪  php --version
PHP 7.1.0RC3 (cli) (built: Oct  3 2016 16:32:50) ( NTS )

@coveralls
Copy link
coveralls commented Oct 13, 2016 •
edited
Loading

Coverage Status

Coverage remained the same at 52.034% when pulling e4d48b0 on morozov:use-non-release-version into 63a84f8 on phpbrew:master.

@coveralls
Copy link
coveralls commented Oct 14, 2016 •
edited
Loading

Coverage Status

Coverage decreased (-0.02%) to 52.14% when pulling 0a697b9 on morozov:use-non-release-version into 9de8b3b on phpbrew:master.

@coveralls
Copy link
coveralls commented Nov 5, 2016 •
edited
Loading

Coverage Status

Coverage decreased (-0.09%) to 52.076% when pulling 143e6a0 on morozov:use-non-release-version into 9de8b3b on phpbrew:master.

@coveralls
Copy link
coveralls commented Nov 5, 2016

Coverage Status

Coverage decreased (-0.5%) to 51.703% when pulling 143e6a0 on morozov:use-non-release-version into 9de8b3b on phpbrew:master.

@coveralls
Copy link
coveralls commented Nov 7, 2016

Coverage Status

Coverage decreased (-1.1%) to 51.035% when pulling 589d625 on morozov:use-non-release-version into 9de8b3b on phpbrew:master.

1 similar comment
@coveralls
Copy link
coveralls commented Nov 7, 2016

Coverage Status

Coverage decreased (-1.1%) to 51.035% when pulling 589d625 on morozov:use-non-release-version into 9de8b3b on phpbrew:master.

@coveralls
Copy link
coveralls commented Nov 7, 2016 •
edited
Loading

Coverage Status

Coverage decreased (-0.8%) to 51.409% when pulling 589d625 on morozov:use-non-release-version into 9de8b3b on phpbrew:master.

@coveralls
Copy link
coveralls commented Nov 9, 2016 •
edited
Loading

Coverage Status

Coverage remained the same at 51.376% when pulling e46e21c on morozov:use-non-release-version into e5824f1 on phpbrew:master.

@morozov
Copy link
Contributor Author
morozov commented Nov 9, 2016

@jhdxr mind reviewing this one?

@jhdxr jhdxr merged commit ac50b61 into phpbrew:master Nov 17, 2016
@morozov morozov deleted the use-non-release-version branch December 1, 2016 19:01
@morozov morozov mentioned this pull request Nov 30, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@morozov @coveralls @jhdxr

Comments
0