Do not compress the PHAR#1197
Merged
morozov merged 2 commits intophpbrew:masterfrom Oct 13, 2020
morozov:un-bz2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There have been quite some complaints that the gzip and bzip2 compression of the PHAR introduced in #1082 and #1122 respectively impact the overall user experience. In fact, if one upgrades to the version that uses compression w/o having the corresponding extension at runtime, everything gets broken and there's no way back.
As part of getting rid of the compression, I'd like to get rid of the huge
multi-sapi-5.3.29-homebrew.patchthat was bundled into PHPBrew in #1093. It's unlikely to be used by anyone and still can be applied manually viaphpbrew install --patch.