E51D Use internal oniguruma to build mbstring/mbregex in previous PHP version before 7.4.0 by markwu · Pull Request #1132 · phpbrew/phpbrew · GitHub
[go: up one dir, main page]
Skip to content

Use internal oniguruma to build mbstring/mbregex in previous PHP version before 7.4.0#1132

Merged
morozov merged 1 commit intophpbrew:masterfrom
markwu:fix-mbstring-version-error
Dec 26, 2019
Merged

Use internal oniguruma to build mbstring/mbregex in previous PHP version before 7.4.0#1132
morozov merged 1 commit intophpbrew:masterfrom
markwu:fix-mbstring-version-error

Conversation

@markwu
Copy link
Contributor
@markwu markwu commented Dec 26, 2019 •
edited
Loading

Use internal oniguruma to build mbstring/mbregex in previous PHP version before 7.4.0

morozov
morozov reviewed Dec 26, 2019
View reviewed changes
@markwu markwu closed this Dec 26, 2019
@morozov morozov self-assigned this Dec 26, 2019
@morozov morozov mentioned this pull request Dec 26, 2019
Merged
@markwu markwu reopened this Dec 26, 2019
@markwu
Copy link
Contributor Author
markwu commented Dec 26, 2019 •
edited
Loading

Okay, I think I found the problem.

PHP-5.6.40 and PHP-7.3.13 ships it's own oniguruma, but PHP-7.4.1 doesn't. It located under

~/.phpbrew/build/php-5.6.40/ext/mbstring/oniguruma
~/.phpbrew/build/php-7.3.13/ext/mbstring/oniguruma

I guess PHP-7.(0|1|2) ships with it's ownoniguruma, too.

But, PHP-5.6.40 can only build --enable-mbregex with it's shipped oniguruma, and php-7.3.13 can build --enable-mbregex with both shipped and external oniguruma

So, as you said, maybe we should reopen #1132 to force build previous PHP version (Before PHP-7.4.0) with it's own shipped oniguruma.

That's why homebrew's php formula has additional oniguruma dependency after PHP-7.4.0.

I think I should change the commit to Use internal oniguruma before PHP-7.4.0 instead of Fixed version typo.

@markwu markwu changed the title Fix wrong php version of mbstring variant builder Use internal oniguruma to build mbstring/mbregex in previouse PHP version before 7.4.0 Dec 26, 2019
@markwu markwu changed the title Use internal oniguruma to build mbstring/mbregex in previouse PHP version before 7.4.0 Use internal oniguruma to build mbstring/mbregex in previous PHP version before 7.4.0 Dec 26, 2019
@morozov morozov added Regression A bug that that was introduced as part of a feature or another bug fix and removed Invalid labels Dec 26, 2019
@morozov morozov merged commit 133baec into phpbrew:master Dec 26, 2019
@morozov
Copy link
Contributor
morozov commented Dec 26, 2019

Thanks, @markwu!

@morozov morozov added this to the Release 1.25.2 milestone Dec 26, 2019
@morozov morozov mentioned this pull request Dec 26, 2019
Closed
@markwu markwu deleted the fix-mbstring-version-error branch December 27, 2019 05:07
morozov added a commit that referenced this pull request Dec 31, 2019
@morozov
Merge pull request #1132 from markwu/fix-mbstring-version-error
14d7819 
Use internal oniguruma to build mbstring/mbregex in previous PHP version before 7.4.0
@morozov
Copy link
Contributor
morozov commented Dec 31, 2019

Backported to 1.25 via 14d7819.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@morozov morozov morozov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@morozov morozov

Labels

Regression A bug that that was introduced as part of a feature or another bug fix Variants

Projects

None yet

Milestone

Release 1.25.2

Development

Successfully merging this pull request may close these issues.

2 participants

@markwu @morozov

Comments
0