Fixed duplicate $PHPBREW_PATH in $PATH in Fish#1101
Merged
morozov merged 1 commit intophpbrew:masterfrom Dec 19, 2019
morozov:fish-double-init
Merged
Fixed duplicate $PHPBREW_PATH in $PATH in Fish#1101morozov merged 1 commit intophpbrew:masterfrom morozov:fish-double-init
morozov merged 1 commit intophpbrew:masterfrom
morozov:fish-double-init
Conversation
If PHPBrew is initialized twice: once via `~/.profile` (so that desktop applications have the PHPBrew-managed PHP in $PATH) and once via `~/.config/fish/fish.config` (for applications run via shell), the `$PHPBREW_PATH` will appear in `$PATH` in the Fish shell. It doesn't happen in Bash because `__phpbrew_load_user_config` there calls `__phpbrew_set_path` internally, not something like `export PATH=$PHPBREW_PATH:$PATH`. Additionally, the initialization logic has been moved to the end of the script to make sure all needed functions are declared at the initialization time. Also, `$PATH_WITHOUT_PHPBREW` and `$PHPBREW_VERSION_REGEX` are no longer exported.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If PHPBrew is initialized twice: once via
~/.profile(so that desktop applications have the PHPBrew-managed PHP in $PATH) and once via~/.config/fish/fish.config(for applications run via shell), the$PHPBREW_PATHwill appear in$PATHin the Fish shell.Without additional configuration, it can be reproduced in shell:
It doesn't happen in Bash because
__phpbrew_load_user_configthere calls__phpbrew_set_pathinternally, not something likeexport PATH=$PHPBREW_PATH:$PATH.Additionally, the initialization logic has been moved to the end of the script to make sure all needed functions are declared at the initialization time.
Also,
$PATH_WITHOUT_PHPBREWis no longer exported.