Removing the development dependency on corneltek/phpunit-testmore#1089
Merged
morozov merged 1 commit intophpbrew:masterfrom Dec 11, 2019
morozov:remove-test-more
Merged
Removing the development dependency on corneltek/phpunit-testmore#1089morozov merged 1 commit intophpbrew:masterfrom morozov:remove-test-more
morozov merged 1 commit intophpbrew:masterfrom
morozov:remove-test-more
Conversation
The package is unmaintained and is incompatible with PHPUnit 7 and newer PHPUnit versions which enforce scalar parameter types in their APIs. By helping to save a few keystrokes (which is the job for an IDE), it promotes too generic assertions like `ok()` and `not_ok()` while the PHPUnit's [best practices][1] suggest the opposite: > Use the most specific assertion available to express what you want to test [1]: http://assets.en.oreilly.com/1/event/45/PHPUnit%20Best%20Practices%20Presentation.pdf
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The package is unmaintained and is incompatible with PHPUnit 7 and newer PHPUnit versions which enforce scalar parameter types in their APIs.
By helping to save a few keystrokes (which is the job for an IDE), it promotes too generic assertions like
ok()andnot_ok()while the PHPUnit's best practices suggest the opposite: