Code cleanup#1087
Merged
morozov merged 4 commits intophpbrew:masterfrom Dec 11, 2019
morozov:code-cleanup
Merged
Conversation
The classes were used only for detection of the number of processors which was only used in a couple of tests while the actual code didn't use this number. It is easier and more reliable to use MAKE_FLAGS that is controlled by the end user and is used by make consistenly across all tasks.
The class was used as an alternative to version_compare and was too complex for that purpose. Additionally, the test was rewritten to not specify the museum flag. Otherwise, I'd always pass even if the implementation had been broken.
Replaced the usages with a simple exec().
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MachineandProcessclasses. The classes were used only for detection of the number of processors which was only used in a couple of tests while the actual code didn't use this number. It is easier and more reliable to useMAKE_FLAGSthat is controlled by the user and is used bymakeconsistently across all tasks.Versionclass. The class was used as an alternative toversion_compare()and was too complex for that purpose. Additionally, the test was rewritten to not specify the museum flag. Otherwise, I'd always pass even if the implementation had been broken.Utils::pipeExecute(). Replaced the usages with a simpleexec().