When doing a self-update, download the file from GitHub releases instead of the repository#1084
Merged
morozov merged 1 commit intophpbrew:masterfrom Dec 11, 2019
morozov:self-update
Merged
When doing a self-update, download the file from GitHub releases instead of the repository#1084morozov merged 1 commit intophpbrew:masterfrom morozov:self-update
morozov merged 1 commit intophpbrew:masterfrom
morozov:self-update
Conversation
…ead of the repository
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Having the built PHAR in the source tree is annoying since IDEs pick up its content and use for static analysis, completion, etc. It's not part of the source tree, cannot be merged, blamed, yadda yadda yadda.
As of now, GitHub supports linking to the latest release which we can leverage instead.
TODO:
self-updatecommand and documentation to point to the GitHub release instead of a blob in the source tree.