Speed up slow tests on PHP 5#1079
Merged
morozov merged 1 commit intophpbrew:masterfrom Dec 8, 2019
morozov:phpunit-speedup
Merged
Speed up slow tests on PHP 5#1079morozov merged 1 commit intophpbrew:masterfrom morozov:phpunit-speedup
morozov merged 1 commit intophpbrew:masterfrom
morozov:phpunit-speedup
Conversation
1. `InstallCommandTest::testKnownCommand()` communicates to php.net which is slow on Travis and is only needed as a dependency for `::testInstallCommand()` which is skipped on Travis. Combined them together. 2. Skip `ExtensionInstallerTest::testPackageUrl()` on Travis since VCR cannot properly record the binary file downloaded by the test. 3. Refreshed and reorganized recordings for some other commands.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The slowest tests are:
Summary of the changes:
InstallCommandTest::testKnownCommand()communicates to php.net which is slow on Travis and is only needed as a dependency for::testInstallCommand()which is skipped on Travis. Combined them together.ExtensionInstallerTest::testPackageUrl()on Travis since VCR cannot properly record the binary file downloaded by the test.The slowest suites are down from 15+ minutes to 2 minutes.