8000 Remove AppStore by theofidry · Pull Request #1068 · phpbrew/phpbrew · GitHub
[go: up one dir, main page]

Skip to content

Comments

Remove AppStore#1068

Closed
theofidry wants to merge 1 commit intophpbrew:masterfrom
theofidry:feature/remove-app-store
8000
Closed

Remove AppStore#1068
theofidry wants to merge 1 commit intophpbrew:masterfrom
theofidry:feature/remove-app-store

Conversation

@theofidry
Copy link
Contributor
@theofidry theofidry commented Dec 6, 2019

See the original discussion in #988.

@theofidry
Copy link
Contributor Author

Hm, I don't quite get how that works I guess :/

@morozov
Copy link
Contributor
morozov commented Dec 6, 2019

Hm, I don't quite get how that works I guess :/

What do you mean? From the test failures, it seems like that there are some AppStore code leftovers. But besides that, I'd first like to deprecate this functionality and then remove it. Removing it just like that might be too harsh.

@jhdxr
Copy link
Member
jhdxr commented Dec 7, 2019

I'd first like to deprecate this functionality and then remove it.

Agreed. Removing a future in a minor upgrade without any deprecation is really a bad idea IMO.

btw, could you provide some justification for this removal?

@jhdxr
Copy link
Member
jhdxr commented Dec 7, 2019

ok. I got why you propose this PR. but I still prefer to remove it in a major upgrade. (maybe someone could help me to remove the deprecated --mirror option at the same time)

@theofidry
Copy link
Contributor Author
theofidry commented Dec 7, 2019 via email

@morozov
Copy link
Contributor
morozov commented Dec 11, 2019

but I still prefer to remove it in a major upgrade

Given the current lack of users and maintainers, it might be too much burden to adhere to semantic versioning. The way I see it right now is: fix regressions in patch releases, add new features, deprecate and remove the old ones in minor releases. At the current state, a major release is out of the question, IMO.

maybe someone could help me to remove the deprecated --mirror option at the same time

Removed in #1083.

@morozov
Copy link
Contributor
morozov commented Dec 11, 2019

#1088 is filed to deprecate the component first.

@theofidry
Copy link
Contributor Author

Let's close this one in favour of #1088 then :)

@theofidry theofidry closed this Dec 11, 2019
@theofidry theofidry deleted the feature/remove-app-store branch July 1, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

0