8000 Support connection_name parameter for custom connection names in RabbitMQ by supersmile2009 · Pull Request #363 · php-amqp/php-amqp · GitHub
[go: up one dir, main page]
Skip to content

Support connection_name parameter for custom connection names in RabbitMQ #363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Feb 27, 2020
Merged

Support connection_name parameter for custom connection names in RabbitMQ #363

merged 8 commits into from
Feb 27, 2020

Conversation

supersmile2009
Copy link
Contributor

This PR adds support for connection_name parameter.
It can be used to pass custom connection name to RabbitMQ, which is shown in the management console like this:
Screenshot from 2020-01-28 16-07-34

@supersmile2009 supersmile2009 force-pushed the feature/connection-name branch from 99bc636 to ab06b2f Compare January 30, 2020 14:49
@lstrojny
Copy link
Collaborator
lstrojny commented Feb 3, 2020

Short glimpse, looks good! Could you add a test where you explicitly set the connection name to NULL?

@supersmile2009
Copy link
Contributor Author

@lstrojny done. Good point BTW, had to fix setConnectionName method which was casting null to empty string.

Do you have any plans on merging #334 ? There are a couple of conflicts between my PR and that one. If that PR is merged first I'd be happy to quickly rebase my branch. And having that PR merged is especially good since its author did a great job of fixing tests.

@lstrojny
Copy link
Collaborator

Awesome, I'll merge #334 first and then you can rebase. Thank you!

@lstrojny
Copy link
Collaborator

#334 is merged

@supersmile2009 supersmile2009 force-pushed the feature/connection-name branch from 0a11ff9 to b085bda Compare February 24, 2020 16:14
@supersmile2009 supersmile2009 force-pushed the feature/connection-name branch from b085bda to 71a717e Compare February 26, 2020 20:15
@supersmile2009
Copy link
Contributor Author

@lstrojny Ready. I rebased the branch and fixed a couple more tests, which got broken because of the new property in var_dumps.

@lstrojny
Copy link
Collaborator

Awesome, thank you!

@lstrojny lstrojny merged commit e474b8b into php-amqp:master Feb 27, 2020
@supersmile2009 supersmile2009 mentioned this pull request Mar 26, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@supersmile2009 @lstrojny
0