8000 Store default values of parameters of internal functions in arginfo by kocsismate · Pull Request #5353 · php/php-src · GitHub
[go: up one dir, main page]
Skip to content

Store default values of parameters of internal functions in arginfo #5353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 14 commits into from
Closed

Store default values of parameters of internal functions in arginfo #5353

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
ea43d8c
Store default parameter values of internal functions in arg info
kocsismate Apr 6, 2020
fe52d36
Update stubs
kocsismate Apr 6, 2020
d45d179
Update tests
kocsismate Apr 6, 2020
4a8a22d
Address code review comments
kocsismate Apr 7, 2020
4266358
Try to reorganize language scanner dependencies
kocsismate Apr 7, 2020
62f170e
Revert "Try to reorganize language scanner dependencies"
nikic Apr 8, 2020
7cf5852
Fix typo
nikic Apr 8, 2020
a3d1850
Extract as zend_compile_string_to_ast() function
nikic Apr 8, 2020
157f390
Remove reflection part of genfiles
nikic Apr 8, 2020
59b902f
Handle simple cases more efficiently
nikic Apr 8, 2020
1942986
Forward declare _zend_arena struct
nikic Apr 8, 2020
18ddd11
Handle a few more cases in the fast-path
nikic Apr 8, 2020
1cdbe90
Code cleanup
nikic Apr 8, 2020
dd62bcd
Initialize file context
nikic Apr 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Initialize file context
  • Loading branch information
@nikic
nikic committed Apr 8, 2020
commit dd62bcdcbb3569fcc68ecc477451b286807cf30c
3 changes: 3 additions & 0 deletions ext/reflection/php_reflection.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1314,12 +1314,15 @@ static int get_default_via_ast(zval *default_value_zval, const char *default_val

zend_arena *original_ast_arena = CG(ast_arena);
uint32_t original_compiler_options = CG(compiler_options);
zend_file_context original_file_context;
CG(ast_arena) = ast_arena;
/* Disable constant substitution, to make getDefaultValueConstant() work. */
CG(compiler_options) |= ZEND_COMPILE_NO_CONSTANT_SUBSTITUTION | ZEND_COMPILE_NO_PERSISTENT_CONSTANT_SUBSTITUTION;
zend_file_context_begin(&original_file_context);
zend_const_expr_to_zval(default_value_zval, const_expression_ast);
CG(ast_arena) = original_ast_arena;
CG(compiler_options) = original_compiler_options;
zend_file_context_end(&original_file_context);

zend_ast_destroy(ast);
zend_arena_destroy(ast_arena);
Expand Down
0