8000 Make `zend_register_*_constant()` functions return pointers, use them by DanielEScherzer · Pull Request #19029 · php/php-src · GitHub
[go: up one dir, main page]
Skip to content

Make zend_register_*_constant() functions return pointers, use them #19029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Make zend_register_*_constant() functions return pointers, use them #19029

wants to merge 3 commits into from

Conversation

DanielEScherzer
Copy link
Member

Have each of the specialized methods for registering a constant return a pointer to the registered constant the same way that the generic zend_register_constant() function does, and use those in the generated arginfo files to avoid needing to search for a constant that was just registered in order to add attributes to it.

@DanielEScherzer
Make zend_register_*_constant() functions return pointers, use them
f78fd03 
Have each of the specialized methods for registering a constant return a
pointer to the registered constant the same way that the generic
`zend_register_constant()` function does, and use those in the generated
arginfo files to avoid needing to search for a constant that was just
registered in order to add attributes to it.
@DanielEScherzer
Copy link
Member Author

Cross link #18969 and #18780

devnexen
devnexen approved these changes Jul 4, 2025
View reviewed changes
Copy link
Member
@devnexen devnexen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes make sense to me

nielsdos
nielsdos approved these changes Jul 4, 2025
View reviewed changes
Copy link
Member
@nielsdos nielsdos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, it's less startup code bloat and it shouldn't break BC because the function returned void previously. Also shouldn't be more costly since it just keeps the return register the same.

@nielsdos
Copy link
Member
nielsdos commented Jul 4, 2025

Actually, will the changes to gen_stub work when generating arginfo for versions below 8.5?

@TimWolla TimWolla removed their request for review July 4, 2025 10:02
@DanielEScherzer
Copy link
Member Author
DanielEScherzer commented Jul 4, 2025 •
edited
Loading

Actually, will the changes to gen_stub work when generating arginfo for versions below 8.5?

Good catch, ext/zend_test/test_arginfo.h shows that it would have broken - fixed, you can see that zend_test is no longer affected by this change since it supports PHP 8.0+

kocsismate
kocsismate reviewed Jul 4, 2025
View reviewed changes
@DanielEScherzer @kocsismate
Update build/gen_stub.php
c866325 
Co-authored-by: Máté Kocsis <kocsismate90@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devnexen devnexen devnexen approved these changes

@kocsismate kocsismate kocsismate approved these changes

@nielsdos nielsdos nielsdos approved these changes

@bukka bukka Awaiting requested review from bukka bukka is a code owner

@zeriyoshi zeriyoshi Awaiting requested review from zeriyoshi zeriyoshi is a code owner

@kamil-tekiela kamil-tekiela Awaiting requested review from kamil-tekiela kamil-tekiela is a code owner

@derickr derickr Awaiting requested review from derickr derickr is a code owner

@adoy adoy Awaiting requested review from adoy adoy is a code owner

Assignees
No one assigned
Labels
ABI break Category: Build System Category: Engine Extension: curl Extension: date Extension: dom Extension: enchant Extension: filter Extension: mysqli Extension: pgsql Extension: random Extension: soap Extension: standard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DanielEScherzer @nielsdos @devnexen @kocsismate
0