10000 ext/spl: Refactor ArrayObject sort methods by Girgias · Pull Request #19023 · php/php-src · GitHub
[go: up one dir, main page]
Skip to content

ext/spl: Refactor ArrayObject sort methods #19023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 3, 2025
+139 −25
Merged

ext/spl: Refactor ArrayObject sort methods #19023

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ce83d37
ext/spl: Add tests for disabled sort functions
Girgias Jul 3, 2025
0c3ee42
ext/spl: Refactor ArrayObject sort methods
Girgias Jul 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
ext/spl: Add tests for disabled sort functions
  • Loading branch information
@Girgias
Girgias committed Jul 3, 2025
commit ce83d373f9cba3608414724a88561fb364c45fc6
18 changes: 18 additions & 0 deletions ext/spl/tests/ArrayObject/asort_disabled.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
--TEST--
ArrayObject when function asort() is disabled
--INI--
disable_functions=asort
--FILE--
<?php
$a = ['hello', 'world', 'SPL', 'is', 'fun', '!'];
$ao = new ArrayObject($a);
$ao->asort();
var_dump($ao);

?>
--EXPECTF--
Fatal error: Uncaught Error: Invalid callback asort, function "asort" not found or invalid function name in %s:%d
Stack trace:
#0 %s(%d): ArrayObject->asort()
#1 {main}
thrown in %s on line %d
18 changes: 18 additions & 0 deletions ext/spl/tests/ArrayObject/ksort_disabled.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
--TEST--
ArrayObject when function ksort() is disabled
--INI--
disable_functions=ksort
--FILE--
<?php
$a = ['hello', 'world', 'SPL', 'is', 'fun', '!'];
$ao = new ArrayObject($a);
$ao->ksort();
var_dump($ao);

?>
--EXPECTF--
Fatal error: Uncaught Error: Invalid callback ksort, function "ksort" not found or invalid function name in %s:%d
Stack trace:
#0 %s(%d): ArrayObject->ksort()
#1 {main}
thrown in %s on line %d
18 changes: 18 additions & 0 deletions ext/spl/tests/ArrayObject/natcasesort_disabled.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
--TEST--
ArrayObject when function natcasesort() is disabled
--INI--
disable_functions=natcasesort
--FILE--
<?php
$a = ['hello', 'world', 'SPL', 'is', 'fun', '!'];
$ao = new ArrayObject($a);
$ao->natcasesort();
var_dump($ao);

?>
--EXPECTF--
Fatal error: Uncaught Error: Invalid callback natcasesort, function "natcasesort" not found or invalid function name in %s:%d
Stack trace:
#0 %s(%d): ArrayObject->natcasesort()
#1 {main}
thrown in %s on line %d
18 changes: 18 additions & 0 deletions ext/spl/tests/ArrayObject/natsort_disabled.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
--TEST--
ArrayObject when function natsort() is disabled
--INI--
disable_functions=natsort
--FILE--
<?php
$a = ['hello', 'world', 'SPL', 'is', 'fun', '!'];
$ao = new ArrayObject($a);
$ao->natsort();
var_dump($ao);

?>
--EXPECTF--
Fatal error: Uncaught Error: Invalid callback natsort, function "natsort" not found or invalid function name in %s:%d
Stack trace:
#0 %s(%d): ArrayObject->natsort()
#1 {main}
thrown in %s on line %d
18 changes: 18 additions & 0 deletions ext/spl/tests/ArrayObject/uasort_disabled.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
--TEST--
ArrayObject when function uasort() is disabled
--INI--
disable_functions=uasort
--FILE--
<?php
$a = ['hello', 'world', 'SPL', 'is', 'fun', '!'];
$ao = new ArrayObject($a);
$ao->uasort(fn ($l, $r) => $l <=> $r);
var_dump($ao);

?>
--EXPECTF--
Fatal error: Uncaught Error: Invalid callback uasort, function "uasort" not found or invalid function name in %s:%d
Stack trace:
#0 %s(%d): ArrayObject->uasort(Object(Closure))
#1 {main}
thrown in %s on line %d
18 changes: 18 additions & 0 deletions ext/spl/tests/ArrayObject/uksort_disabled.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
--TEST--
ArrayObject when function uksort() is disabled
--INI--
disable_functions=uksort
--FILE--
<?php
$a = ['hello', 'world', 'SPL', 'is', 'fun', '!'];
$ao = new ArrayObject($a);
$ao->uksort(fn ($l, $r) => $l <=> $r);
var_dump($ao);

?>
--EXPECTF--
Fatal error: Uncaught Error: Invalid callback uksort, function "uksort" not found or invalid function name in %s:%d
Stack trace:
#0 %s(%d): ArrayObject->uksort(Object(Closure))
#1 {main}
thrown in %s on line %d
0