10000 Fix PHP_BUILD_CRT input in the nightly workflow by shivammathur · Pull Request #18982 · php/php-src · GitHub
[go: up one dir, main page]
Skip to content

Fix PHP_BUILD_CRT input in the nightly workflow #18982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 30, 2025
Merged

Fix PHP_BUILD_CRT input in the nightly workflow #18982

merged 1 commit into from
Jun 30, 2025

Conversation

shivammathur
Copy link
Member
@shivammathur shivammathur commented Jun 30, 2025 •
edited
Loading

We are now using windows-2022 for all supported PHP versions, so the PHP_BUILD_CRT version should be correctly based on the PHP version.

@shivammathur shivammathur requested a review from iluuu1994 June 30, 2025 13:52
iluuu1994
iluuu1994 approved these changes Jun 30, 2025
View reviewed changes
Copy link
Member
@iluuu1994 iluuu1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Shivam!

@shivammathur shivammathur merged commit 8ddc210 into php:PHP-8.1 Jun 30, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iluuu1994 iluuu1994 iluuu1994 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shivammathur @iluuu1994
0