zend_language_scanner: Lex clone as identifier when followed by (
#18981
+10
−39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This greatly simplifies the parser to support `clone()` as a function and effectively reverts php#18938. Co-authored-by: Ilija Tovilo <ilija.tovilo@me.com>
iluuu1994
approved these changes
Jun 30, 2025
|
Okay, it appears that this doesn't actually work, because it breaks |
|
I just saw. I'm ok keeping it the way it is. |
nikic
reviewed
Jul 2, 2025
| @@ -1613,6 +1613,11 @@ OPTIONAL_WHITESPACE_OR_COMMENTS ({WHITESPACE}|{MULTI_LINE_COMMENT}|{SINGLE_LINE_ | |||
| RETURN_TOKEN_WITH_IDENT(T_NEW); | |||
| } | |||
|
|
|||
| <ST_IN_SCRIPTING>"clone"{OPTIONAL_WHITESPACE_OR_COMMENTS}"(" { | |||
| yyless(5); | |||
| RETURN_TOKEN_WITH_STR(T_NAME_FULLY_QUALIFIED, 0); | |||
There was a problem hiding this comment.
Would lexing it as T_STRING instead work?
There was a problem hiding this comment.
That would work, but “require” a special case in the compiler to treat clone($x, $y) in a namespace as a fully-qualified call.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This greatly simplifies the parser to support
clone()as a function and effectively reverts #18938.