8000 Fix GH-17345: Bug #35916 was not completely fixed by nielsdos · Pull Request #18973 · php/php-src · GitHub
[go: up one dir, main page]
Skip to content

Fix GH-17345: Bug #35916 was not completely fixed #18973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: PHP-8.3
Choose a base branch
from
Open

Fix GH-17345: Bug #35916 was not completely fixed #18973

wants to merge 1 commit into from

Conversation

nielsdos
Copy link
Member

Change the reproducer code in bug35916.phpt from stream_bucket_append to stream_bucket_prepend and you have the same bug. Furthermore, even in the append case the check is incorrect because the bucket can already be in the brigade at a position other than the tail. To solve this properly, unlink the brigade first and also use that as a condition to manage the refcount.

@nielsdos
Fix phpGH-17345: Bug #35916 was not completely fixed
7cc599a 
Change the reproducer code in `bug35916.phpt` from `stream_bucket_append` to
`stream_bucket_prepend` and you have the same bug.
Furthermore, even in the append case the check is incorrect because the bucket
can already be in the brigade at a position other than the tail.
To solve this properly, unlink the brigade first and also use that as a
condition to manage the refcount.
@nielsdos nielsdos linked an issue Jun 28, 2025 that may be closed by this pull request
Bug #35916 was not completely fixed #17345
Open
@nielsdos nielsdos marked this pull request as ready for review June 28, 2025 23:36
@nielsdos nielsdos requested a review from bukka as a code owner June 28, 2025 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bukka bukka Awaiting requested review from bukka bukka is a code owner

Assignees
No one assigned
Labels
Extension: standard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug #35916 was not completely fixed
1 participant
@nielsdos
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
0