8000 Fixed bug #71868: Environment variables with no value are filtered out by proc_open() by matason · Pull Request #1881 · php/php-src · GitHub
[go: up one dir, main page]
Skip to content

Fixed bug #71868: Environment variables with no value are filtered out by proc_open() #1881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
matason wants to merge 1 commit into from
Closed

Fixed bug #71868: Environment variables with no value are filtered out by proc_open() #1881

matason wants to merge 1 commit into from

Conversation

@matason
Copy link
Contributor
@matason matason commented Apr 21, 2016

By removing the code that skips empty array values.

@nikic nikic changed the title Fixed bug #71868 in master Fixed bug #71868: Environment variables with no value are filtered out by proc_open() Apr 23, 2016
@krakjoe
Copy link
Member
krakjoe commented Jun 8, 2016

@matason CI is failing, can you review the test please.

@matason
Copy link
Contributor Author
matason commented Jun 8, 2016

@krakjoe Sure, sorry for the delay, I'll have a look this evening.

@matason
Copy link
Contributor Author
matason commented Jun 9, 2016

Hi @krakjoe, I exchanged calling php directly with $php = PHP_BINARY and that fixed the one failure that appeared to be related to my changes however, I still get 3 failures on what, at least at first glance, seem to be unrelated tests:

IntlTimeZone::createDefault(): basic test [ext/intl/tests/timezone_createDefault_basic.phpt]
Playing with SELECT FORMAT(...) AS _format - see also bugs.php.net/42378 [ext/mysqli/tests/mysqli_stmt_bind_result_format.phpt]
apache_request_headers() stack overflow. [sapi/cgi/tests/apache_request_headers.phpt]

I'll take a closer look at those tests, I also noted the use of $php = getenv('TEST_PHP_EXECUTABLE'); in some tests, I'm not sure what the difference is between the two methods but will take a look at that as an aside...

@matason
Copy link
Contributor Author
matason commented Jun 22, 2016

Right, I'm getting a clearer understanding of why the tests fail, I'll close this pull request whilst I work on a solution.

@matason matason closed this Jun 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@matason @krakjoe
0