8000 Fix out of tree build by arnaud-lb · Pull Request #18716 · php/php-src · GitHub
[go: up one dir, main page]
Skip to content

Fix out of tree build #18716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 2, 2025
Merged

Fix out of tree build #18716

merged 1 commit into from
Jun 2, 2025

Conversation

arnaud-lb
Copy link
Member

This fixes the following error when building out of the source tree:

ext/uri/uriparser/src/UriCompare.c:41:10: fatal error: uriparser/UriDefsConfig.h: No such file or directory
   41 | #include <uriparser/UriDefsConfig.h>

I add $ext_srcdir/$URIPARSER_DIR/include to the include path instead of $ext_builddir/$URIPARSER_DIR/include, so that files are searched in the source tree. The extension doesn't appear to generate include files in the build dir.

@arnaud-lb arnaud-lb marked this pull request as ready for review June 1, 2025 09:44
@TimWolla TimWolla requested a review from kocsismate June 1, 2025 11:06
@kocsismate kocsismate mentioned this pull request Jun 2, 2025
Merged
@kocsismate kocsismate merged commit f64e3d5 into php:master Jun 2, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kocsismate kocsismate kocsismate approved these changes

Assignees
No one assigned
Labels
Category: Build System Extension: uri
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arnaud-lb @kocsismate
0