[RFC] Add RFC 3986 and WHATWG compliant URL parsing support #14461
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kocsismate
commented
Jun 3, 2024
| @@ -3715,7 +3715,6 @@ function uniqid(string $prefix = "", bool $more_entropy = false): string {} | |||
|
|
|||
| /** | |||
| * @return int|string|array<string, int|string>|null|false | |||
| * @compile-time-eval | |||
There was a problem hiding this comment.
Removed for benchmarking purposes
ext/url/php_url.c
Outdated
|
|
||
| static void cleanup_parser(void) | ||
| { | ||
| if (++URL_G(urls) % 500 == 0) { |
There was a problem hiding this comment.
Approach is copy-pasted from lexbor/lexbor#206
823e4c6 to
e65deb7
Compare
nielsdos
reviewed
Jun 15, 2024
bukka
reviewed
Jul 8, 2024
0ccffa0 to
04d4e6e
Compare
8000
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2nd take after the failed experiment with #11315
RFC: https://wiki.php.net/rfc/url_parsing_api