chore(ci): only trigger time consuming steps when relevant#1714
Merged
chore(ci): only trigger time consuming steps when relevant#1714
Conversation
dunglas
approved these changes
Jul 1, 2025
AlliBalliBaba
approved these changes
Jul 5, 2025
Contributor
There was a problem hiding this comment.
Additional patterns can also be added later on 👍
Member
Author
|
Most definitely! |
Member
|
Thanks! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because of the numerous platforms FrankenPHP supports, dozens of Docker images are built every time we push something in a branch. This leads to bottlenecks when multiple pushes are performed in a short amount of time (from 1 to 15 minutes). It can then happens several hours before jobs are picked up by Github runners.
I propose to keep linters, sanitizers and tests for every push. They are quick to run and give immediate feedback on PR health.
Building static bin and dozens of Docker images is the real pain point, therefore I propose to only run them at merge on main and when some specific files are edited. I added a list of glob patterns, feel free to comment which you think should also be added.