8000 fix: ctrl-click in mac app and safari didnt open context menu by abose · Pull Request #1994 · phcode-dev/phoenix · GitHub
[go: up one dir, main page]
Skip to content

fix: ctrl-click in mac app and safari didnt open context menu #1994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
abose merged 1 commit into from
Dec 17, 2024
Merged

fix: ctrl-click in mac app and safari didnt open context menu #1994

abose merged 1 commit into from
Dec 17, 2024

Conversation

@abose
Copy link
Member
@abose abose commented Dec 17, 2024 •
edited
Loading

Fixes: https://github.com/orgs/phcode-dev/discussions/1993

This issue existed from our first desktop version released in Apr 2024 which used the safari engine. In the desktop app, we cant open context menus with ctrl-click on mac as it will get dismissed as soon as it opens.
This is a mac desktop and safari only issue with ctrl-click based context menu activation. Context menu activation with right mouse button click works as expected.
The issue happens only in safari as it treats ctrl-click based right click in mac differently:

  • In Chrome, when you Cmd+Click, it treats it as a special context menu event and doesn't trigger the normal click handlers
  • In Safari, Cmd+Click generates both a context menu event AND a regular click event, which triggers the clearMenus handler. The twin calls leads to the context menu getting dismissed as the second event gets treated as a click event outside popup to dismiss it.
  • We now account for this safari quirk.

@sonarqubecloud
Copy link
sonarqubecloud bot commented Dec 17, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@abose abose merged commit f047fb7 into main Dec 17, 2024
17 of 18 checks passed
@abose abose deleted the y branch December 17, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@abose
0