fix: mitigate alert and confirm apis not working in embeded live preview in windows desktop #1750
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iew in windows desktop
Member
Thank You for making this pull request. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address: https://github.com/orgs/phcode-dev/discussions/1734
tracking tauri issue: https://discordapp.com/channels/616186924390023171/1258736272814374964
In Windows desktop apps, DOM alert and Confirm api is not working from iframe. Prompt API works. It works as expected in Mac/Linux.
The fix is that since prompt api works, i have used a hack to use prompt api when someone calls alert(). Sine alert() pauses js ontext, this has to be done and we could not rely on a pure js rendered alert dialog box.