Minor cleanup of the code handling the shared memory cache for principal keys #409
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was no point in having the function for attaching the the shared memory hash table be inline if the non-inlined code had to be called every time anyway. We still maybe should just stop using an explicit inline since this is unlikely to be that performace critical code but at least if we use it we should use it correctly.
There was no good reason to have an upper case H.
Codecov ReportAll modified and coverable lines are covered by tests ✅
❌ Your project status has failed because the head coverage (85.50%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## TDE_REL_17_STABLE #409 +/- ##
=====================================================
- Coverage 85.55% 85.50% -0.05%
=====================================================
Files 22 22
Lines 2547 2546 -1
Branches 388 388
=====================================================
- Hits 2179 2177 -2
- Misses 292 293 +1
Partials 76 76
🚀 New features to boost your workflow:
|
AndersAstrand
approved these changes
Jun 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
2ED3
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the case of the name of the
get_principal_key_hash()function plus makes our use of an explicitly inlined function sane. Before this the inlined function always had to call the non-inlined one defeating the entire purpose. Of course there is a good argument for just removing this cleverness because it is a not that performance critical path plus that everything is static functions so the compiler should be able to do a good enough job even without explicit inline.