Ensure the cluster process is dead in tests #350
Merged
+23
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes kill -9 might take a bit longer than what it takes for us to restart the server. Wait for the process to actually die before continuing. This is to fix the CI failures these tests often had.
567229f to
3553dde
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❌ Your project status has failed because the head coverage (80.49%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## TDE_REL_17_STABLE #350 +/- ##
==================================================
Coverage 80.49% 80.49%
==================================================
Files 22 22
Lines 2604 2604
Branches 398 398
==================================================
Hits 2096 2096
Misses 430 430
Partials 78 78
🚀 New features to boost your workflow:
|
dAdAbird
approved these changes
May 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6423
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes kill -9 might take a bit longer than what it takes for us to restart the server. Wait for the process to actually die before continuing.
This is to fix the CI failures these tests often had.
I have now slept on this and isn't as annoyed as I was yesterday 😆 . I think this is the better solution.
Replaces #348 and #349