[PG-1531] Verify that key provider can provide any in-use keys before it's updated #347
+205
−266
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove some pointless variable usage, move variable to smaller scope and clean up some newlines.
Prevent the change if they do not. In the future we might want to add a "force" parameter, but for now the command line utility can be used while the cluster is offline if that is necessary.
Codecov ReportAttention: Patch coverage is
❌ Your project status has failed because the head coverage (80.36%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## TDE_REL_17_STABLE #347 +/- ##
=====================================================
- Coverage 80.49% 80.36% -0.14%
=====================================================
Files 22 22
Lines 2605 2633 +28
Branches 398 407 +9
=====================================================
+ Hits 2097 2116 +19
- Misses 430 438 +8
- Partials 78 79 +1
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously you could just change your key provider settings to something that couldn't retrieve your keys that were already in-use. Now we verify that the new settings would provide the same keys as the old ones.