Fix build when cassert is not set #341
8000
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
None of our other init functions does this, and without cassert the compiler complains about the initialized value of initialized is unused.
It was already set up to throw an error if connection failed, and the unused result prevented compilation without cassert defined.
42225ec to
7b25902
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❌ Your project status has failed because the head coverage (80.49%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## TDE_REL_17_STABLE #341 +/- ##
=====================================================
- Coverage 80.49% 80.49% -0.01%
=====================================================
Files 22 22
Lines 2605 2604 -1
Branches 398 398
=====================================================
- Hits 2097 2096 -1
Misses 430 430
Partials 78 78
🚀 New features to boost your workflow:
|
dAdAbird
approved these changes
May 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Variables that are only ever used for
Assert()breaks the build when asserts aren't enabled, as the compiler complains about unused variables.