8000 Always kill web servers used in tests by AndersAstrand · Pull Request #332 · percona/postgres · GitHub
[go: up one dir, main page]
Skip to content

Always kill web servers used in tests #332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 14, 2025
Merged

Always kill web servers used in tests #332

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Always kill web servers used in tests 
Previously these processes would stay around if the test script crashed
or was otherwise aborted before reaching the kill command.
  • Loading branch information
@AndersAstrand
AndersAstrand committed May 14, 2025
commit 0a62e837cb956a026cb846eca65c3608229d79fd
3 changes: 1 addition & 2 deletions contrib/pg_tde/t/003_remote_config.pl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@
}

my $pid = MyWebServer->new(8888)->background();
END { kill('TERM', $pid); }

PGTDE::setup_files_dir(basename($0));

Expand Down Expand Up @@ -85,8 +86,6 @@

$node->stop;

kill('TERM', $pid);

# Compare the expected and out file
my $compare = PGTDE->compare_results();

Expand Down
3 changes: 1 addition & 2 deletions contrib/pg_tde/t/006_remote_vault_config.pl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@
}

my $pid = MyWebServer->new(8889)->background();
END { kill('TERM', $pid); }

PGTDE::setup_files_dir(basename($0));

Expand Down Expand Up @@ -94,8 +95,6 @@

$node->stop;

kill('TERM', $pid);

# Compare the expected and out file
my $compare = PGTDE->compare_results();

Expand Down
0