[PG-1583, PG-1600] Do not unnecessarily try to fetch the principal key #330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
❌ Your project status has failed because the head coverage (80.50%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## TDE_REL_17_STABLE #330 +/- ##
=====================================================
+ Coverage 80.28% 80.50% +0.21%
=====================================================
Files 22 22
Lines 2577 2600 +23
Branches 395 400 +5
=====================================================
+ Hits 2069 2093 +24
Misses 428 428
+ Partials 80 79 -1
🚀 New features to boost your workflow:
|
057705e to
8e38fb1
Compare
Replace the boolean used in the smgr hooks. Currently we only have two states still. This is in preparation for adding a third state to indicate that the table is encrypted, but the key has not yet been loaded.
In many cases it's completely unnecessary to have the principal key in order to know if a relation is encrypted or not. This simplifies cases where principal key provider is not available for any reason. The unencrypted key should most likely be cached, but this commit does not do that.
Don't decrypt relation keys until they're actually needed. In some cases tde_mdopen() is called after the transaction is committed which means that we're not longer able to abort the transaction if we fail when we fetch the principal key. This happens, for example, if dropping an encrypted table. Previously this would cause postmaster to panic if it didn't have access to the principal key.
8e38fb1 to
1a04d5d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tde_mdopen()andtde_mdunlink()can be called after the transaction is committed, in which case it's too late to abort the transaction with ereport(ERROR) if we fail to fetch the principal key.This PR defers the loading of relation keys until they're actually needed, so that we won't unnecessarily try to fetch the principal key.
There is obviously room for optimizations here, for example by caching the still encrypted relation keys instead of looking them up in the map file again when they're actually needed. But this is not included in this PR as we have PG-1436 for investigating the performance of this caching.