Revoke all from publi 8000 c on c functions #318
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❌ Your project status has failed because the head coverage (80.33%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## TDE_REL_17_STABLE #318 +/- ##
=====================================================
+ Coverage 80.29% 80.33% +0.03%
=====================================================
Files 22 22
Lines 2578 2578
Branches 396 396
=====================================================
+ Hits 2070 2071 +1
+ Misses 428 427 -1
Partials 80 80
🚀 New features to boost your workflow:
|
Even though we do have some access control in most of our C functions, it seems dangerous to not revoke them from public by default. A whitelist of allowed functions seems safer than a black list.
fecffc9 to
eaa8f25
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It feels better to have a white list of publicly executable functions than a black list.
I wasn't sure where tests that asserts that CREATE EXTENSION does the right thing belongs, but it felt like basic usage to me so I put the assertion that this is done there.
We don't have any security definer functions, but if we did they would also need to be revoked from public by default.