-
Notifications
You must be signed in to change notification settings - Fork 9
Fix whitespace in all non-Markdown files #314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Every text file (with the exception of test output) should end in exactly one newline.
No text file should begin with a newline.
While in theory it could be useful to separate blocks with double empty lines nobody does that consistently so we might as well only ever use one empty line.
3c40170
to
03b51d3
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❌ Your project status has failed because the head coverage (80.36%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## TDE_REL_17_STABLE #314 +/- ##
==================================================
Coverage 80.36% 80.36%
==================================================
Files 22 22
Lines 2541 2541
Branches 395 395
==================================================
Hits 2042 2042
Misses 420 420
Partials 79 79
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The last commit message have an extra "t" at the end of "no". But it also doesn't mention that markdown files needs to have extra whitespace at end of line considering it's significant there 😆
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved changes, thank you for the linting!
With the exception of test output files no text file should have extra whitesapce and the end of line.
Modified the structure and overall presentation for the users to make it more accessible and future-proof as we improve pg_tde moving forward. Split big chapters into smaller chunks to improve SEO, renamed a couple of files for better visibility online and cleaned a bit of text. Integrated changes from: - #314 - #306 - Commit f636e82
Files for which we do not use pgindent or perltidy could have whitespace at and of line or miss the newline at end of file but while at it also remove some extra newlines in the middle of files since we never used those consistently enough for them to be useful.