8000
  • fix(Table): updated logic for expandable class by thatblindgeye · Pull Request #11918 · patternfly/patternfly-react · GitHub
    [go: up one dir, main page]
    Skip to content

    fix(Table): updated logic for expandable class#11918

    Merged
    dlabaj merged 2 commits intopatternfly:mainfrom
    thatblindgeye:tableExpandableFix
    Jul 11, 2025
    Merged

    fix(Table): updated logic for expandable class#11918
    dlabaj merged 2 commits intopatternfly:mainfrom
    thatblindgeye:tableExpandableFix

    Conversation

    @thatblindgeye
    Copy link
    Contributor
    @thatblindgeye thatblindgeye commented Jul 10, 2025

    What: Closes #11916

    Tested pulling in patternfly/patternfly#7654 (comment) locally with these React updates, in both expandable and compound expandable examples:

    • The examples currently on staging work still as expected
    • Copying the examples from main (without any of these recent updates where props are being passed in as they should have been) and pasting into examples work as expected
    • Same as above bullet point, except also passing in the isExpanded logic to the "control" Tr work as expected

    Additional issues:

    @patternfly-build
    Copy link
    Collaborator
    patternfly-build commented Jul 10, 2025 •
    edited
    Loading

    Preview: https://patternfly-react-pr-11918.surge.sh

    A11y report: https://patternfly-react-pr-11918-a11y.surge.sh

    @thatblindgeye thatblindgeye marked this pull request as ready for review July 11, 2025 15:17
    dlabaj
    dlabaj approved these changes Jul 11, 2025
    View reviewed changes
    Copy link
    Contributor
    @dlabaj dlabaj left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    LGTM.

    @dlabaj dlabaj merged commit 2b6c99b into patternfly:main Jul 11, 2025
    13 checks passed
    @patternfly-build
    Copy link
    Collaborator
    patternfly-build commented Jul 11, 2025

    Your changes have been released in:

    • @patternfly/react-charts@8.3.0-prerelease.19
    • @patternfly/react-code-editor@6.3.0-prerelease.30
    • @patternfly/react-core@6.3.0-prerelease.30
    • @patternfly/react-docs@7.3.0-prerelease.37
    • @patternfly/react-drag-drop@6.3.0-prerelease.30
    • @patternfly/react-icons@6.3.0-prerelease.12
    • demo-app-ts@6.0.0-prerelease.133
    • @patternfly/react-styles@6.3.0-prerelease.11
    • @patternfly/react-table@6.3.0-prerelease.30
    • @patternfly/react-templates@6.3.0-prerelease.30
    • @patternfly/react-tokens@6.3.0-prerelease.11

    Thanks for your contribution! 🎉

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Reviewers

    @dlabaj dlabaj dlabaj approved these changes

    @mcoker mcoker mcoker approved these changes

    @kmcfaul kmcfaul kmcfaul approved these changes

    @gitdallas gitdallas Awaiting requested review from gitdallas

    @srambach srambach Awaiting requested review from srambach

    +1 more reviewer

    @rebeccaalpert rebeccaalpert rebeccaalpert approved these changes

    Reviewers whose approvals may not affect merge requirements

    Assignees

    @thatblindgeye thatblindgeye

    Labels

    Do Not Merge

    Projects

    None yet

    Milestone

    No milestone

    Development

    Successfully merging this pull request may close these issues.

    Bug - Table - 6.3.0 prerelease issues

    6 participants

    @thatblindgeye @patternfly-build @dlabaj @rebeccaalpert @mcoker @kmcfaul
    0