8000 Sankey chart (1 of 2) by dlabrecq · Pull Request #11616 · patternfly/patternfly-react · GitHub
[go: up one dir, main page]
Skip to content

Sankey chart (1 of 2)#11616

Merged
thatblindgeye merged 1 commit intopatternfly:mainfrom
dlabrecq:sankey
Mar 18, 2025
Merged

Sankey chart (1 of 2)#11616
thatblindgeye merged 1 commit intopatternfly:mainfrom
dlabrecq:sankey

Conversation

@dlabrecq
Copy link
Member
@dlabrecq dlabrecq commented Mar 6, 2025 •
edited
Loading

Created Sankey and Line charts, based on Apache ECharts.

Note the Line chart was added to help nail-down some boilerplate features such as theme colors and properties, custom legend tooltips, and skeletons. This should make it easier to add more ECharts (e.g., Bar) in the future.

Sankey chart (2 of 2): #11622 (doc updates only)
Closes: #10817

@patternfly-build
Copy link
Collaborator
patternfly-build commented Mar 6, 2025 •
edited
Loading

Preview: https://patternfly-react-pr-11616.surge.sh

A11y report: https://patternfly-react-pr-11616-a11y.surge.sh

@dlabrecq dlabrecq force-pushed the sankey branch 3 times, most recently from 1eef77e to 9f62631 Compare March 6, 2025 13:47
@dlabrecq dlabrecq marked this pull request as ready for review March 6, 2025 15:22
@dlabrecq dlabrecq mentioned this pull request Mar 6, 2025
Merged
@dlabrecq dlabrecq changed the title Sankey chart feat(charts): ECharts 1 of 2 Mar 6, 2025
@dlabrecq dlabrecq changed the title feat(charts): ECharts 1 of 2 Sankey chart (1 of 2) Mar 6, 2025
@dlabrecq dlabrecq requested review from nicolethoen and tlabaj March 10, 2025 14:16
@dlabrecq dlabrecq mentioned this pull request Mar 10, 2025
Closed
@thatblindgeye thatblindgeye requested review from a team and mmenestr and removed request for a team March 10, 2025 17:40
@thatblindgeye thatblindgeye requested review from a team, bekah-stephens and lboehling and removed request for a team March 10, 2025 17:40
lboehling
lboehling approved these changes Mar 11, 2025
View reviewed changes
Copy link
Collaborator
@lboehling lboehling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! These look good to me!

@dlabrecq dlabrecq force-pushed the sankey branch 2 times, most recently from b7a3117 to 2f80d5c Compare March 12, 2025 14:20
wise-king-sullyman
wise-king-sullyman reviewed Mar 13, 2025
View reviewed changes
packages/react-charts/src/echarts/components/Line/examples/next/Charts Outdated
@@ -0,0 +1 @@
../../../Charts No newline at end of file
Copy link
Collaborator
@wise-king-sullyman wise-king-sullyman Mar 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious: what's this file doing?

Copy link
Member Author
@dlabrecq dlabrecq Mar 14, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a soft link for docs. Specifically, so the build can find ChartsDoc for the "React next" example.

Copy link
Collaborator
@wise-king-sullyman wise-king-sullyman Mar 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing it locally doesn't seem to change the next line examples from what I can tell 🤔

Copy link
Member Author
@dlabrecq dlabrecq Mar 14, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the soft link. I discovered how to use a relative path with propComponents

@dlabrecq dlabrecq force-pushed the sankey branch 2 times, most recently from 9bf5623 to 1f84f4f Compare March 14, 2025 13:29
wise-king-sullyman
wise-king-sullyman approved the 8000 se changes Mar 14, 2025
View reviewed changes
Copy link
Collaborator
@wise-king-sullyman wise-king-sullyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My questions around the charts symlink aside this looks great.

Really cool stuff 💪

@dlabrecq dlabrecq force-pushed the sankey branch 10 times, most recently from 6f3e235 to 778a5fd Compare March 15, 2025 18:47
@thatblindgeye thatblindgeye merged commit f2479b1 into patternfly:main Mar 18, 2025
13 checks passed
@srtanish1992 srtanish1992 mentioned this pull request Mar 18, 2026
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wise-king-sullyman wise-king-sullyman wise-king-sullyman approved these changes

@nicolethoen nicolethoen nicolethoen approved these changes

@lboehling lboehling lboehling approved these changes

@mfrances17 mfrances17 Awaiting requested review from mfrances17

@tlabaj tlabaj Awaiting requested review from tlabaj

@mmenestr mmenestr Awaiting requested review from mmenestr mmenestr was automatically assigned from patternfly/ux-reviewers

@bekah-stephens bekah-stephens Awaiting requested review from bekah-stephens bekah-stephens was automatically assigned from patternfly/design-reviewers

Assignees

No one assigned

Labels

ux review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Sankey diagram

6 participants

@dlabrecq @patternfly-build @wise-king-sullyman @nicolethoen @lboehling @thatblindgeye
0