fix(Card demo): use proper token#10837
Merged
thatblindgeye merged 3 commits intopatternfly:v6from Aug 14, 2024
Merged
Conversation
Collaborator
|
Preview: https://patternfly-react-pr-10837.surge.sh A11y report: https://patternfly-react-pr-10837-a11y.surge.sh |
Contributor
|
It still does not look right.
Here is this PR:
|
tlabaj
approved these changes
Aug 7, 2024
Contributor
There was a problem hiding this comment.
LGTM
It looks like core's demo is using an image and not an actual chart.
Contributor
Author
|
Core's example will have to be updated with the new color |
Contributor
Author
|
Updated the PR to use the red-orange 400 token based on feedback in slack |
thatblindgeye
approved these changes
Aug 14, 2024
Collaborator
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: Closes #10582
Updates the demo to use the proper red-orange token as the red tokens were removed.