feat: update to latest tokens w/ glass#8096
Merged
mcoker merged 3 commits intopatternfly:mainfrom Feb 9, 2026
Merged
Conversation
Contributor
WalkthroughReplace generic glass background tokens with granular blur and opacity variants (separate primary and floating tokens) across multiple PatternFly theme files; update a few generated header timestamps to Feb 7, 2026. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related issues
Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Collaborator
|
Preview: https://pf-pr-8096.surge.sh A11y report: https://pf-pr-8096-a11y.surge.sh |
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@src/patternfly/base/tokens/tokens-redhat-glass-dark.scss`:
- Line 17: The alias token --pf-t--global--background--color--glass--floating is
emitted out of alphabetical order (it should come before the
--pf-t--global--background--filter--glass--* entries); fix by updating the token
generator to sort tokens/aliases alphabetically before writing them out (or
insert this alias into the sorted position), and regenerate the SCSS so
--pf-t--global--background--color--glass--floating appears in the proper
alphabetical location in all affected token files.
| --pf-t--global--color--brand--accent--clicked: var(--pf-t--global--dark--color--brand--accent--200); | ||
| --pf-t--global--color--brand--accent--default: var(--pf-t--global--dark--color--brand--accent--100); | ||
| --pf-t--global--color--brand--accent--hover: var(--pf-t--global--dark--color--brand--accent--200); | ||
| --pf-t--global--background--color--glass--floating: var(--pf-t--global--background--color--primary--default); |
Contributor
There was a problem hiding this comment.
Token is out of alphabetical order.
--pf-t--global--background--color--glass--floating should appear before --pf-t--global--background--filter--glass--* (line 7) to maintain alphabetical sorting. Since these files are auto-generated, this likely indicates a bug in the token generator that appends this alias at the end instead of inserting it in sorted position. The same issue exists in tokens-glass-dark.scss (line 11) and tokens-redhat-glass.scss (line 17).
🤖 Prompt for AI Agents
In `@src/patternfly/base/tokens/tokens-redhat-glass-dark.scss` at line 17, The
alias token --pf-t--global--background--color--glass--floating is emitted out of
alphabetical order (it should come before the
--pf-t--global--background--filter--glass--* entries); fix by updating the token
generator to sort tokens/aliases alphabetically before writing them out (or
insert this alias into the sorted position), and regenerate the SCSS so
--pf-t--global--background--color--glass--floating appears in the proper
alphabetical location in all affected token files.
Collaborator
|
🎉 This PR is included in version 6.5.0-prerelease.37 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced Feb 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
blur()function.pf-v6-theme-glasslike they used toSummary by CodeRabbit