8000 fix(nav): update animation, fix tab bug by mcoker · Pull Request #7432 · patternfly/patternfly · GitHub
[go: up one dir, main page]

Skip to content

fix(nav): update animation, fix tab bug#7432

Merged
mcoker merged 3 commits intopatternfly:mainfrom
mcoker:issue-7431
Apr 1, 2025
Merged

fix(nav): update animation, fix tab bug#7432
mcoker merged 3 commits intopatternfly:mainfrom
mcoker:issue-7431

Conversation

@mcoker
Copy link
Contributor
@mcoker mcoker commented Apr 1, 2025

fixes #7431
fixes #7430

3 commits

  • 84a0c3b - original approach with transition for opacity and animation for visiblity/focus
  • ba8b9ae - moves visibility to a transition (preferred IMO)
  • 4c16139 - transitions the collapse, too. Not sure if we want to do that but it's there so we can look at it.

@patternfly-build
Copy link
Collaborator
patternfly-build commented Apr 1, 2025

@mcoker mcoker marked this pull request as ready for review April 1, 2025 14:10
Copy link
Collaborator
@andrew-ronaldson andrew-ronaldson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🫶

Copy link
Member
@srambach srambach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Copy link
Contributor
@sg00dwin sg00dwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@mcoker mcoker merged commit 5cbd222 into patternfly:main Apr 1, 2025
4 checks passed
@mcoker mcoker deleted the issue-7431 branch April 1, 2025 18:30
@patternfly-build
Copy link
Collaborator

🎉 This PR is included in version 6.2.0-prerelease.27 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug - Nav - Collapsed nav items are still focusable Bug - Nav - update expandable animation

6 participants

0