chore(multiple): make icon rotation expansion transitions consistent#7392
Merged
mcoker merged 5 commits intopatternfly:mainfrom Mar 13, 2025
Merged
Conversation
Collaborator
|
Preview: https://patternfly-pr-7392.surge.sh A11y report: https://patternfly-pr-7392-a11y.surge.sh |
mcoker
requested changes
Mar 12, 2025
Contributor
There was a problem hiding this comment.
Wired this up to a react dev server to validate and found a few bugs. Also looks like a lot of these don't have to be written as shorthand since they don't require a single --Transition var.
| --#{$form}__field-group-toggle-icon--TransitionDuration: var(--pf-t--global--motion--duration--icon--long); | ||
| --#{$form}__field-group-toggle-icon--TransitionDuration: var(--pf-t--global--motion--duration--icon--default); | ||
| --#{$form}__field-group-toggle-icon--TransitionTimingFunction: var(--pf-t--global--motion--timing-function--default); | ||
| --#{$form}__field-group-toggle-icon--Transition: transform var(---#{$form}__field-group-toggle-icon--TransitionDuration) var(--#{$form}__field-group-toggle-icon--TransitionTimingFunction); // TODO remove in breaking change along with shorthand property |
Contributor
There was a problem hiding this comment.
There is an extra - keeping this animation from working. Though this can be longhand, too - you don't need the --Transition var
Suggested change
| --#{$form}__field-group-toggle-icon--Transition: transform var(---#{$form}__field-group-toggle-icon--TransitionDuration) var(--#{$form}__field-group-toggle-icon--TransitionTimingFunction); // TODO remove in breaking change along with shorthand property | |
| --#{$form}__field-group-toggle-icon--Transition: transform var(--#{$form}__field-group-toggle-icon--TransitionDuration) var(--#{$form}__field-group-toggle-icon--TransitionTimingFunction); // TODO remove in breaking change along with shorthand property |
| --#{$jump-links}__toggle-icon--TransitionDuration: var(--pf-t--global--motion--duration--icon--long); | ||
| --#{$jump-links}__toggle-icon--TransitionDuration: var(--pf-t--global--motion--duration--icon--default); | ||
| --#{$jump-links}__toggle-icon--TransitionTimingFunction: var(--pf-t--global--motion--timing-function--default); | ||
| --#{$jump-links}__toggle-icon--Transition: tranform var(--#{$jump-links}__toggle-icon--TransitionDuration) var(--#{$jump-links}__toggle-icon--TransitionTimingFunction); // TODO remove in breaking change along with shorthand property |
Contributor
There was a problem hiding this comment.
Typo in transform - but you can remove this --Transition var and make it longhand, too.
Suggested change
| --#{$jump-links}__toggle-icon--Transition: tranform var(--#{$jump-links}__toggle-icon--TransitionDuration) var(--#{$jump-links}__toggle-icon--TransitionTimingFunction); // TODO remove in breaking change along with shorthand property | |
| --#{$jump-links}__toggle-icon--Transition: transform var(--#{$jump-links}__toggle-icon--TransitionDuration) var(--#{$jump-links}__toggle-icon--TransitionTimingFunction); // TODO remove in breaking change along with shorthand property |
| @include pf-v6-mirror-inline-on-rtl; | ||
|
|
||
| transition: transform var(--#{$table}__toggle--c-button__toggle-icon--TransitionDuration) var(--#{$table}__toggle--c-button__toggle-icon--TransitionTimingFunction); | ||
| transform: rotate(var(--#{$table}__toggle--c-button__toggle-icon--Rotate)); |
Contributor
There was a problem hiding this comment.
Looks like this was removed accidentally? Currently all toggles point down whether they're expanded or not.
|
|
||
| display: inline-block; | ||
| transition: transform var(--#{$card}__header-toggle-icon--TransitionDuration) var(--#{$card}__header-toggle-icon--TransitionTimingFunction); | ||
| transition: var(--#{$card}__header-toggle-icon--Transition); // TODO remove shorthand in breaking change |
Contributor
There was a problem hiding this comment.
Since --#{$card}__header-toggle-icon--Transition didn't exist before, you don't need to add it and can make it longhand.
| color: var(--#{$dual-list-selector}__item-toggle-icon--Color, inherit); | ||
| text-align: center; | ||
| transition: transform var(--#{$dual-list-selector}__item-toggle-icon--TransitionDuration) var(--#{$dual-list-selector}__item-toggle-icon--TransitionTimingFunction); | ||
| transition: var(--#{$dual-list-selector}__item-toggle-icon--Transition); // TODO remove shorthand in breaking change |
Contributor
There was a problem hiding this comment.
This one can be longhand, too, and you can remove --#{$dual-list-selector}__item-toggle-icon--Transition
| --#{$table}__toggle__icon--Transition: .2s ease-in 0s; | ||
| --#{$table}__toggle-icon--TransitionDuration: var(--pf-t--global--motion--duration--icon--default); | ||
| --#{$table}__toggle-icon--TransitionTimingFunction: var(--pf-t--global--motion--timing-function--default); | ||
| --#{$table}__toggle-icon--Transition: transform var(--#{$table}__toggle-icon--TransitionDuration) var(--#{$table}__toggle-icon--TransitionTimingFunction); // TODO remove in breaking change along with shorthand property |
Contributor
There was a problem hiding this comment.
Needs to retain the old var name so it isn't a breaking change.
Suggested change
| --#{$table}__toggle-icon--Transition: transform var(--#{$table}__toggle-icon--TransitionDuration) var(--#{$table}__toggle-icon--TransitionTimingFunction); // TODO remove in breaking change along with shorthand property | |
| --#{$table}__toggle__icon--Transition: transform var(--#{$table}__toggle-icon--TransitionDuration) var(--#{$table}__toggle-icon--TransitionTimingFunction); // TODO remove in breaking change along with shorthand property |
| // - Table grid toggle icon | ||
| .#{$table}__toggle-icon { | ||
| transition: var(--#{$table}__toggle__icon--Transition); | ||
| transition: var(--#{$table}__toggle-icon--Transition); // TODO remove shorthand in breaking change |
Contributor
There was a problem hiding this comment.
Suggested change
| transition: var(--#{$table}__toggle-icon--Transition); // TODO remove shorthand in breaking change | |
| transition: var(--#{$table}__toggle__icon--Transition); // TODO remove shorthand in breaking change |
| --#{$table}__toggle--c-button__toggle-icon--TransitionDuration: var(--pf-t--global--motion--duration--icon--long); | ||
| --#{$table}__toggle--c-button__toggle-icon--TransitionDuration: var(--pf-t--global--motion--duration--icon--default); | ||
| --#{$table}__toggle--c-button__toggle-icon--TransitionTimingFunction: var(--pf-t--global--motion--timing-function--default); | ||
| --#{$table}__toggle--c-button__toggle-icon--Transition: transform var(--#{$table}__toggle--c-button__toggle-icon--TransitionDuration) var(--#{$table}__toggle--c-button__toggle-icon--TransitionTimingFunction); // TODO remove in breaking change along with shorthand property |
Contributor
There was a problem hiding this comment.
This --Transition var didn't exist before so you can remove it and make the property declarations longhand.
| .#{$toolbar}__expand-all-icon { | ||
| display: inline-flex; | ||
| transition: transform var(--#{$toolbar}__expand-all-icon--TransitionDuration) var(--#{$toolbar}__expand-all-icon--TransitionTimingFunction); | ||
| transition: var(--#{$toolbar}__expand-all-icon--Transition); // TODO remove shorthand in breaking change |
Contributor
There was a problem hiding this comment.
Same here - you can nix the --Transition var and make it a long hand
|
|
||
| display: inline-block; | ||
| transition: transform var(--#{$wizard}__nav-link-toggle-icon--TransitionDuration) var(--#{$wizard}__nav-link-toggle-icon--TransitionTimingFunction); | ||
| transition: var(--#{$wizard}__nav-link-toggle-icon--Transition); // TODO remove shorthand in breaking change |
Contributor
There was a problem hiding this comment.
Same here - you can nix the --Transition var and make it a long hand
Collaborator
|
🎉 This PR is included in version 6.2.0-prerelease.22 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6959
Puts tokens and vars where transitions were hard coded.
Breaks apart shorthand transition into separate properties.
Where the --long duration token was used for the expansion toggle rotation, it was changed to --default (per design team on slack)