8000 chore(text-input-group): add usage documentation by srambach · Pull Request #7388 · patternfly/patternfly · GitHub
[go: up one dir, main page]
Skip to content

chore(text-input-group): add usage documentation#7388

Merged
mcoker merged 2 commits intopatternfly:mainfrom
srambach:6709-docs-text-input-group
Mar 7, 2025
Merged

chore(text-input-group): add usage documentation#7388
mcoker merged 2 commits intopatternfly:mainfrom
srambach:6709-docs-text-input-group

Conversation

@srambach
Copy link
Member
@srambach srambach commented Mar 6, 2025

Fixes #6709

@srambach srambach requested review from mcoker and sg00dwin March 6, 2025 22:20
@patternfly-build
Copy link
Collaborator
patternfly-build commented Mar 6, 2025 •
edited
Loading

Preview: https://patternfly-pr-7388.surge.sh

A11y report: https://patternfly-pr-7388-a11y.surge.sh

mcoker
mcoker requested changes Mar 6, 2025
View reviewed changes
Copy link
Contributor
@mcoker mcoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one thing. We have a __group element

patternfly/src/patternfly/components/TextInputGroup/text-input-group.scss

Lines 238 to 240 in ec18d8d

.#{$text-input-group}__group {
display: flex;
}

I don't see it in any of the core examples, but looks like it's in the react component. It goes in the __utilities element if you specify onNextClick and onPreviousClick, and creates little up/down arrow buttons to navigate the results. https://github.com/patternfly/patternfly-react/blob/b1cf0d2e7da9e7956df74ba20d98bab03cd542af/packages/react-core/src/components/SearchInput/SearchInput.tsx#L314-L329

@srambach @mcoker
Update src/patternfly/components/TextInputGroup/examples/TextInputGro…
6ab75b1 
…up.md

Co-authored-by: Michael Coker <35148959+mcoker@users.noreply.github.com>
@srambach
Copy link
Member Author
srambach commented Mar 7, 2025

Sneaky! Only one style rule and no examples. Thanks for the catch.

mcoker
mcoker approved these changes Mar 7, 2025
View reviewed changes
Copy link
Contributor
@mcoker mcoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤘

@mcoker mcoker merged commit 4370853 into patternfly:main Mar 7, 2025
4 checks passed
@patternfly-build
Copy link
Collaborator
patternfly-build commented Mar 10, 2025

🎉 This PR is included in version 6.2.0-prerelease.17 🎉

The release is available on:

Your semantic-release bot 📦🚀

@patternfly-build patternfly-build mentioned this pull request Apr 16, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcoker mcoker mcoker approved these changes

@sg00dwin sg00dwin Awaiting requested review from sg00dwin

Assignees

No one assigned

Labels

released on @prerelease

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug -Text input group - missing documentation section

3 participants

@srambach @patternfly-build @mcoker
0