chore(tab-content): move tab content under tabs#7381
Conversation
|
Preview: https://patternfly-pr-7381.surge.sh A11y report: https://patternfly-pr-7381-a11y.surge.sh |
There was a problem hiding this comment.
Personally it's probably fine for now re: titling. The titles are unique on the page so it should e fine.
Eventually it might be good to rethink the naming convention for examples and the structures, but waiting until we get the new docs framework up would be better since we may have more flexibility with how we can structure things (e.g. maybe something like ## Tab examples > ### Basic > the example itself if there's really only 1 example (rather than "Examples" > "Default" > "Default tab example" > the example itself), and ## Tab examples > ### Overflow > #### Beginning of list > the example itself etc).
But again, not something to do here either way, just thinking out loud.
There was a problem hiding this comment.
Good to go with @thatblindgeye points
|
🎉 This PR is included in version 6.2.0-prerelease.18 🎉 The release is available on: Your semantic-release bot 📦🚀 |
fixes #7328
I left the tabs example titles alone in case someone saved/bookmarked them. Lemme know if you'd prefer update any of them (for example "Default" to "Default tabs", or under tab content "Secondary" to "Secondary tab content").