8000 fix(menu toggle): remove bg secondary by andrew-ronaldson · Pull Request #7242 · patternfly/patternfly · GitHub
[go: up one dir, main page]

Skip to content

fix(menu toggle): remove bg secondary#7242

Merged
mcoker merged 2 commits intopatternfly:mainfrom
andrew-ronaldson:menu-toggle-bg
Jan 9, 2025
Merged

fix(menu toggle): remove bg secondary#7242
mcoker merged 2 commits intopatternfly:mainfrom
andrew-ronaldson:menu-toggle-bg

Conversation

@andrew-ronaldson
Copy link
Collaborator

Closes #7241

@patternfly-build
Copy link
Collaborator
patternfly-build commented Dec 2, 2024

Copy link
Contributor
@mcoker mcoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I reckon we should also update the expanded bg?

--#{$menu-toggle}--m-secondary--expanded--BackgroundColor: transparent;
Screenshot 2024-12-05 at 9 30 20 PM

Making the secondary styling have a transparent background on expanded
Copy link
Contributor
@mcoker mcoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍👍

@mcoker mcoker requested a review from srambach January 7, 2025 02:37
Copy link
Member
@srambach srambach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done 👻

@mcoker mcoker 8000 merged commit 301034d into patternfly:main Jan 9, 2025
@patternfly-build
Copy link
Collaborator

🎉 This PR is included in version 6.2.0-prerelease.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug - Menu toggle - Remove background on Secondary button styling

4 participants

0