fix: fixes z-index issue with wizard navigation.#7218
fix: fixes z-index issue with wizard navigation.#7218mcoker merged 2 commits intopatternfly:mainfrom
Conversation
|
Preview: https://patternfly-pr-7218.surge.sh A11y report: https://patternfly-pr-7218-a11y.surge.sh |
|
I believe the reason it was using the other z-index was so that the shadow from the nav didn't sit on top of the footer when expanded on mobile and the nav extends the height of the wizard and has a scrollbar. For reference: This is the shadow when it doesn't extend the full height of the wizard, lovely and perfect 
And here's what it looks like currently on org when the nav extends the full height. Note the shadow is hidden underneath the footer. That was by design when we created the wizard. 
And here's what it looks like in this PR 
Looks OK to me personally but would love design's feedback. WDYT @lboehling or @andrew-ronaldson? Is this OK or think we should look at it some more and either try to hide the shadow again or make some other kind of update? |
|
I think hide the shadow like the Pre-PR screenshot shows. |
|
@andrew-ronaldson I'd like to merge this PR to fix the issue in #7001 (it's more wide-spread than just a toggle group - lots of things would exploit this bug) and follow-up to fix the shadow, which may be tricker to solve. WDYT - can we live with the shadow for now? |
|
sounds good. Thanks for the update |
|
🎉 This PR is included in version 6.1.0-prerelease.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Fixes issue #7001 by setting the z-index correctly for the wizard navigation.